kitty: make possible to override goModules#241707
Merged
Artturin merged 1 commit intoNixOS:masterfrom Jul 6, 2023
Merged
Conversation
go-modules name had to be changed to goModules so it becomes a env
var (bash vars can't contain -)
enables overriding the build without overriding configurePhase
```
pkgs.kitty.overrideAttrs (finalAttrs: previousAttrs: {
name = "kitty-master";
version = "master";
src = pkgs.fetchFromGitHub {
owner = "kovidgoyal";
repo = "kitty";
rev = "66a2efd191f98a1a5b3c2d4fdc9569204b445a2f";
sha256 = "sha256-pJuhnJOjGBflHXOOYKrg9/e3c+VGEESZtfka84ARCd4=";
};
goModules = (pkgs.buildGoModule {
pname = "kitty-go-modules";
inherit (finalAttrs) src version;
vendorHash = "sha256-eAovZ/7JnvXlnlFyt0skhYJ1Nrzy2XCpRlQvSmWCyaY=";
}).go-modules;
})
```
adamcstephens
approved these changes
Jul 6, 2023
Contributor
adamcstephens
left a comment
There was a problem hiding this comment.
Built successfully on all supported platforms.
Contributor
|
Sadly this seems to have broken the update script's vendorHash updating. :( |
Member
Author
|
Checking out if we can just rename all go-modules to goModules and change nix-update |
Contributor
|
I've included this fix in the version bump #242896 Thanks for the quick response! |
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-modules name had to be changed to goModules so it becomes a env var (bash vars can't contain -)
enables overriding the build without overriding configurePhase
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)