maintainers: add script for checking unstable version strings#241428
Open
rhendric wants to merge 1 commit intoNixOS:masterfrom
Open
maintainers: add script for checking unstable version strings#241428rhendric wants to merge 1 commit intoNixOS:masterfrom
rhendric wants to merge 1 commit intoNixOS:masterfrom
Conversation
6 tasks
Member
There was a problem hiding this comment.
Suggested change
| set -o errexit -o nounset -o pipefail | |
| set -eou pipefail |
Comment on lines
61
to
63
Member
There was a problem hiding this comment.
Creating a new worktree takes quite a bit of time on my machines. It would probably be a good idea to have an option to just use the current worktree.
aa4bdbe to
9ee76ce
Compare
Member
Author
|
@SuperSandro2000 Feedback addressed. |
Contributor
There was a problem hiding this comment.
Please link to that file on GitHub, otherwise one has to do manual steps to find out details.
This script is mainly to address complaints that the new unstable version format policy makes it difficult for PR reviewers to verify that an unstable version is correct.
9ee76ce to
a3f7ac5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script is mainly to address complaints that the new unstable version format policy makes it difficult for PR reviewers to verify that an unstable version is correct.
Try it out on some recent PRs:
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)