Skip to content

cctools-port: fix build with clang 16 on x86_64-darwin#240654

Merged
wegank merged 1 commit intoNixOS:stagingfrom
reckenrode:cctools-port-clang16
Jul 4, 2023
Merged

cctools-port: fix build with clang 16 on x86_64-darwin#240654
wegank merged 1 commit intoNixOS:stagingfrom
reckenrode:cctools-port-clang16

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

@reckenrode reckenrode commented Jun 30, 2023

Description of changes

Clang 16 fails to build even with open_memstream disabled. Just use the memstream package to provide an implementation.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 30, 2023
@reckenrode reckenrode mentioned this pull request Jun 30, 2023
Closed
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Jun 30, 2023
@ofborg ofborg bot requested a review from matthewbauer June 30, 2023 05:46
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 30, 2023
wegank
wegank reviewed Jun 30, 2023
View reviewed changes
@reckenrode
cctools-port: fix build with clang 16 on x86_64-darwin
cf77dee 
Clang 16 fails to build even with `open_memstream` disabled. Just use
the memstream package to provide an implementation.
@reckenrode reckenrode force-pushed the cctools-port-clang16 branch from fff9450 to cf77dee Compare June 30, 2023 21:13
@wegank
Copy link
Copy Markdown
Member

wegank commented Jul 3, 2023 •
edited
Loading

@ofborg build rustc

@reckenrode
Copy link
Copy Markdown
Contributor Author

reckenrode commented Jul 3, 2023

It timed out building llvm. Is that expected?

@wegank
Copy link
Copy Markdown
Member

wegank commented Jul 4, 2023 •
edited
Loading

Yeah, that's normal. Built successfully on my machine.

@wegank wegank merged commit 297886f into NixOS:staging Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank left review comments

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reckenrode @wegank