opensp: fix build with clang 16#240645
Merged
wegank merged 1 commit intoNixOS:stagingfrom Jun 30, 2023
Merged
Conversation
There are two issues preventing a build with clang 16: * The configure scripts are too old and generate invalid `config.h`. This is fixed by using `autoreconfHook` with clang. * Use of the `register` storage class specifier, which is not allowed in C++17 (the default when building with clang 16). This is fixed by removing that usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
There are two issues preventing a build with clang 16:
config.h. This is fixed by usingautoreconfHookwith clang.registerstorage class specifier, which is not allowed in C++17 (the default when building with clang 16). This is fixed by removing that usage.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)