Merged
Conversation
wegank
reviewed
Jun 30, 2023
Contributor
Author
There was a problem hiding this comment.
The patch changes a .l file, so flex needs to be run again.
This issue is actually fixed upstream, but there hasn’t been a release. I’ve pushed an updated PR that uses the commits from upstream instead of vendoring the patch.
Contributor
Author
There was a problem hiding this comment.
I also added a comment explaining why flex is required.
Fix implicit `int` on `main` and `static` declarations. Clang 16 reports these as errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix implicit
intonmainandstaticdeclarations. Clang 16 reports these as errors.Testing was done building the reworked Darwin stdenv with clang 16, which succeeded.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)