boost{175,176,177,178,179,180}: clang 16 and libc++ 15 fixes#240642
Merged
wegank merged 2 commits intoNixOS:stagingfrom Jun 30, 2023
Merged
boost{175,176,177,178,179,180}: clang 16 and libc++ 15 fixes#240642wegank merged 2 commits intoNixOS:stagingfrom
wegank merged 2 commits intoNixOS:stagingfrom
Conversation
libc++ 15 dropped support for `std::unary_function` and `std::binary_function` in C++17 and C++20. C++17 is the default for clang 16, but clang 15 is also affected in those language modes. This incompatibility is fixed in Boost 1.81, but the late patch for Boost 1.80 applies to earlier versions and allows those versions to build with clang 16 (and clang 15 in the affected modes).
Clang 16 began diagnosing ill-formed constant expressions for values outside the range of enums without a fixed underlying type. While the error can be suppressed, it will become a hard error in clang 17.
Member
|
@ofborg build boost175 boost177 boost178 boost179 boost180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
These fixes are upstream in the latest version. These commits cherry pick the patches back to the currently provided boost packages in nixpkgs to allow them to build with clang 16 and libc++ 15+ once the Darwin stdenv is updated.
Compilation of all boost packages was tested. Builds were tested with packages that had boost as a dependency.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)