jq: fix build with clang 16 on Darwin#240640
Merged
7c6f434c merged 1 commit intoNixOS:stagingfrom Jun 30, 2023
Merged
Conversation
The configure script for jq 1.6 does not define certain symbols required on Darwin to make `drem`, `significand`, and `lgamma_r` available. This works fine on clang 11 but fails with clang 16. This is fixed upstream. It can be removed once NixOS#217345 is merged or jq is released and updated to 1.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The configure script for jq 1.6 does not define certain symbols required on Darwin to make
drem,significand, andlgamma_ravailable. This works fine on clang 11 but fails with clang 16.This is fixed upstream. It can be removed once #217345 is merged or jq is released and updated to 1.7.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)