Skip to content

python310Packages.numpy: run tests correct so that actually fail the build#240409

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:numpy-fail-tests
Jul 6, 2023
Merged

python310Packages.numpy: run tests correct so that actually fail the build#240409
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:numpy-fail-tests

Conversation

@SuperSandro2000
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 commented Jun 28, 2023 •
edited
Loading

Description of changes

This is broken since 2016 63cf61e

see 63cf61e

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 28, 2023
@mweinelt mweinelt marked this pull request as draft June 28, 2023 20:57
@SuperSandro2000 SuperSandro2000 changed the title python310Packages.numpy: run tests according to README so that they a… python310Packages.numpy: run tests correct so that actually fail the build Jun 28, 2023
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jun 28, 2023

Drafted, because we obviously cannot leave numpy in a failing state.

numpy> ERROR lib/python3.10/site-packages/numpy/core/tests/test_cython.py::test_is_timedelta64_object - subprocess.CalledProcessError: Command '['/nix/store/5a457g4zr7q11b4mz0ifc9...
numpy> ERROR lib/python3.10/site-packages/numpy/core/tests/test_cython.py::test_is_datetime64_object - subprocess.CalledProcessError: Command '['/nix/store/5a457g4zr7q11b4mz0ifc9...
numpy> ERROR lib/python3.10/site-packages/numpy/core/tests/test_cython.py::test_get_datetime64_value - subprocess.CalledProcessError: Command '['/nix/store/5a457g4zr7q11b4mz0ifc9...
numpy> ERROR lib/python3.10/site-packages/numpy/core/tests/test_cython.py::test_get_timedelta64_value - subprocess.CalledProcessError: Command '['/nix/store/5a457g4zr7q11b4mz0ifc9...
numpy> ERROR lib/python3.10/site-packages/numpy/core/tests/test_cython.py::test_get_datetime64_unit - subprocess.CalledProcessError: Command '['/nix/store/5a457g4zr7q11b4mz0ifc9...
numpy> ERROR lib/python3.10/site-packages/numpy/core/tests/test_cython.py::test_abstract_scalars - subprocess.CalledProcessError: Command '['/nix/store/5a457g4zr7q11b4mz0ifc9...

@ofborg ofborg bot requested a review from FRidh June 28, 2023 21:16
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 28, 2023
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review June 28, 2023 21:30
@SuperSandro2000
Copy link
Copy Markdown
Member Author

SuperSandro2000 commented Jun 28, 2023

Drafted, because we obviously cannot leave numpy in a failing state.

Those tests seem to be broken/unable to run in the sandbox. I just removed the file and now python3.pkgs.nump build successful.

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jun 28, 2023

numpy<2.0 pins a specific setuptools version

https://github.com/numpy/numpy/blob/v1.25.0/pyproject.toml#L7

with 2.0 it will rely on meson-python.

@doronbehar doronbehar mentioned this pull request Jun 29, 2023
Closed
1 task
SuperSandro2000
SuperSandro2000 commented Jul 5, 2023
View reviewed changes
@SuperSandro2000 SuperSandro2000 merged commit 87956df into NixOS:staging Jul 6, 2023
@SuperSandro2000 SuperSandro2000 deleted the numpy-fail-tests branch July 6, 2023 20:00
@misuzu misuzu mentioned this pull request Aug 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @mweinelt