mtrace: use makeFlags and standard buildPhase#238029
Closed
Conversation
added 2 commits
June 15, 2023 20:14
This commit allows to include `makeFlags` in a glibc derivation without clobbering the flags from `common.nix`
This commit causes `glibc/mtrace.nix` to use `makeFlags` and the standard `buildPhase` in order to be more overrideAttrs-friendly.
Ma27
requested changes
Jun 17, 2023
Member
Ma27
left a comment
There was a problem hiding this comment.
This breaks mtrace for me with exec format error because of an empty shebang in ./result/bin/mtrace.
Also, this can be targeted against master directly.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit causes
glibc/mtrace.nixto usemakeFlagsand the standardbuildPhasein order to be more overrideAttrs-friendly.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)