volk: add -DVOLK_CPU_FEATURES=OFF if isPower64#237267
Closed
Conversation
Three of the volk tests segfault on powerpc64le without `-DVOLK_CPU_FEATURES=OFF`. Let's add `-DVOLK_CPU_FEATURES=OFF` so the tests pass. ``` volk> 136/139 Test #135: qa_volk_8u_conv_k7_r2puppet_8u ....................... Passed 0.03 sec volk> 137/139 Test #97: qa_volk_32fc_s32fc_multiply_32fc .....................***Failed 0.16 sec volk> RUN_VOLK_TESTS: volk_32fc_s32fc_multiply_32fc(131071,1) volk> /build/source/build/lib/volk_32fc_s32fc_multiply_32fc_test.sh: line 6: 1388 Segmentation fault (core dumped) volk_test_all volk_32fc_s32fc_multiply_32fc volk> 138/139 Test #107: qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc ....***Failed 0.15 sec volk> RUN_VOLK_TESTS: volk_32fc_x2_s32fc_multiply_conjugate_add_32fc(131071,1) volk> Volk warning: no arch found, returning generic impl volk> /build/source/build/lib/volk_32fc_x2_s32fc_multiply_conjugate_add_32fc_test.sh: line 6: 1407 Segmentation fault (core dumped) volk_test_all volk_32fc_x2_s32fc_multiply_conjugate_add_32fc volk> 139/139 Test #98: qa_volk_32fc_s32fc_rotatorpuppet_32fc ................***Failed 0.17 sec volk> RUN_VOLK_TESTS: volk_32fc_s32fc_rotatorpuppet_32fc(131071,1) volk> /build/source/build/lib/volk_32fc_s32fc_rotatorpuppet_32fc_test.sh: line 6: 1390 Segmentation fault (core dumped) volk_test_all volk_32fc_s32fc_rotatorpuppet_32fc volk> 98% tests passed, 3 tests failed out of 139 volk> Total Test time (real) = 0.37 sec volk> The following tests FAILED: volk> 97 - qa_volk_32fc_s32fc_multiply_32fc (Failed) volk> 98 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed) volk> 107 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed) volk> Errors while running CTest volk> make: *** [Makefile:71: test] Error 8 error: build of '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' on 'ssh://root@sterling' failed: builder for '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' failed with exit code 2 error: builder for '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' failed with exit code 1; last 10 log lines: > 98% tests passed, 3 tests failed out of 139 > > Total Test time (real) = 0.37 sec > > The following tests FAILED: > 97 - qa_volk_32fc_s32fc_multiply_32fc (Failed) > 98 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed) > 107 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed) > Errors while running CTest > make: *** [Makefile:71: test] Error 8 For full logs, run 'nix log /nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv'. ```
Author
|
Nope, this doesn't fix it. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Three of the volk tests segfault on powerpc64le without
-DVOLK_CPU_FEATURES=OFF. Let's add-DVOLK_CPU_FEATURES=OFFso the tests pass.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)