dtc: fix overrides: use finalAttrs, not rec#237102
Merged
thiagokokada merged 1 commit intomasterfrom Jun 11, 2023
unknown repository
Merged
dtc: fix overrides: use finalAttrs, not rec#237102thiagokokada merged 1 commit intomasterfrom unknown repository
thiagokokada merged 1 commit intomasterfrom
unknown repository
Conversation
Prior to this commit, dtc was accessing its own derivation
attributes via `rec`. This means that
```
overrideAttrs (_: { doCheck = ..; })
```
will produce inconsistent behavior, with part of the derivation
seeing the old value and part seeing the new value.
finalAttrs is the preferred way to do this. Let's switch to that.
otavio
approved these changes
Jun 11, 2023
thiagokokada
approved these changes
Jun 11, 2023
1 task
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Prior to this commit, dtc was accessing its own derivation attributes via
rec. This means thatwill produce inconsistent behavior, with part of the derivation seeing the old value and part seeing the new value.
finalAttrs is the preferred way to do this. Let's switch to that.
Things done