Skip to content

nss: 3.89.1 -> 3.90#236270

Merged
mweinelt merged 2 commits intoNixOS:masterfrom
helsinki-systems:upd/nss
Jun 20, 2023
Merged

nss: 3.89.1 -> 3.90#236270
mweinelt merged 2 commits intoNixOS:masterfrom
helsinki-systems:upd/nss

Conversation

@ajs124
Copy link
Copy Markdown
Member

@ajs124 ajs124 commented Jun 6, 2023 •
edited by mweinelt
Loading

Description of changes

https://github.com/nss-dev/nss/blob/NSS_3_90_BRANCH/doc/rst/releases/nss_3_90.rst

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 mentioned this pull request Jun 6, 2023
Merged
12 tasks
@ajs124 ajs124 marked this pull request as ready for review June 6, 2023 12:27
@ajs124 ajs124 requested review from lukegb and mweinelt as code owners June 6, 2023 12:27
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 6, 2023
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jun 6, 2023

Waiting for https://bugzilla.mozilla.org/show_bug.cgi?id=1836925

@mweinelt mweinelt marked this pull request as draft June 6, 2023 14:35
drupol
drupol approved these changes Jun 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mweinelt mweinelt mentioned this pull request Jun 17, 2023
Merged
12 tasks
@mweinelt mweinelt marked this pull request as ready for review June 20, 2023 12:49
@mweinelt
nss_latest: remove curve25519 support
2e5b94d 
Was enabled unconditionally, but causes SIGILL on machines that do not
support the Intel ADX instruction extensions.
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 20, 2023
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jun 20, 2023

Tested on my X201t (Arrandale CPU) laptop. No SIGILL encountered on Firefox.

@mweinelt mweinelt merged commit fd41470 into NixOS:master Jun 20, 2023
@mweinelt mweinelt deleted the upd/nss branch June 20, 2023 20:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2023

Backport failed for release-22.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.11
git worktree add -d .worktree/backport-236270-to-release-22.11 origin/release-22.11
cd .worktree/backport-236270-to-release-22.11
git checkout -b backport-236270-to-release-22.11
ancref=$(git merge-base 289d9cf8a7d58086328e78cfc29b267596a0a2de 2e5b94de00fa9735d6fe8d4892c8bee113f7a726)
git cherry-pick -x $ancref..2e5b94de00fa9735d6fe8d4892c8bee113f7a726

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2023

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-236270-to-release-23.05 origin/release-23.05
cd .worktree/backport-236270-to-release-23.05
git checkout -b backport-236270-to-release-23.05
ancref=$(git merge-base 289d9cf8a7d58086328e78cfc29b267596a0a2de 2e5b94de00fa9735d6fe8d4892c8bee113f7a726)
git cherry-pick -x $ancref..2e5b94de00fa9735d6fe8d4892c8bee113f7a726

This was referenced Jun 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@lukegb lukegb Awaiting requested review from lukegb

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajs124 @mweinelt @drupol