Closed
Conversation
Clang 16 defaults to C++17, which does not allow the `register` storage class specifier. This is fixed upstream and will be included in 1.23.0, but the commit with the fixes does not apply cleanly, so a patch is provided instead of using `fetchpatch`.
toonn
reviewed
Jun 19, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
I'm keeping my eye on this. However, it's looking like the 1.23 release of Groff might not be far off and I'm hopeful we can avoid carrying the big patch ourselves.
I consider waiting for the next release feasible until such time as this becomes a true blocker.
Contributor
Author
|
According to the latest status update, it looks a release is imminent (possibly this week). I’ll keep this PR open until it the new version is released in case #241692 is merged before that happens, and we need to fix the groff build in the meantime. |
Contributor
Author
|
Closing in favor of #241870. |
Member
|
Great work on this @reckenrode!! (Un)fortunately(?) groff 1.23.0 has been released making the changes proposed in this PR no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Clang 16 defaults to C++17, which does not allow the
registerstorage class specifier. This is fixed upstream and will be included in 1.23.0, but the commit with the fixes does not apply cleanly, so a patch is provided instead of usingfetchpatch.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)