Skip to content

zeromq: fix build on clang 16 and GCC 13#235503

Closed
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
reckenrode:zeromq-clang
Closed

zeromq: fix build on clang 16 and GCC 13#235503
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
reckenrode:zeromq-clang

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

@reckenrode reckenrode commented Jun 2, 2023

Description of changes

Fixes a static assertion failure regarding rebinding an allocator on clang 16. According to the source PR, this also affects GCC 13.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
zeromq: fix build on clang 16 and GCC 13
ba993de 
Fixes a static assertion failure regarding rebinding an allocator on
clang 16. According to the source PR, this also affects GCC 13.
@reckenrode reckenrode mentioned this pull request Jun 2, 2023
Closed
@ofborg ofborg bot requested a review from fpletz June 2, 2023 03:41
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 2, 2023
@reckenrode
Copy link
Copy Markdown
Contributor Author

reckenrode commented Jun 6, 2023

This was addressed by #234879.

@reckenrode reckenrode closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reckenrode