Skip to content

xfce.mousepad: allow to disable polkit#235360

Merged
bobby285271 merged 1 commit intomasterfrom
unknown repository
Jul 22, 2023
Merged

xfce.mousepad: allow to disable polkit#235360
bobby285271 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 1, 2023

Description of changes

mousepad recently accrued a polkit dependency. This commit allows
to disable that dependency via enablePolkit, like many other
polkitized packages.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

mousepad recently accrued a `polkit` dependency.  This commit allows
to disable that dependency via `enablePolkit`, like many other
polkitized packages.
@github-actions github-actions bot added the 6.topic: xfce The Xfce Desktop Environment label Jun 1, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 1, 2023
@ghost ghost requested a review from bobby285271 July 20, 2023 22:43
@bobby285271 bobby285271 changed the title mousepad: allow to disable polkit xfce.mousepad: allow to disable polkit Jul 22, 2023
@bobby285271 bobby285271 merged commit 12303c6 into NixOS:master Jul 22, 2023
@bobby285271
Copy link
Copy Markdown
Member

Should be fine to me. I think the only difference is it won't install ./share/polkit-1/actions/org.xfce.mousepad.policy?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 24, 2023

The main difference is that it won't depend on polkit.

@ghost ghost deleted the pr/mousepad/enablePolkit branch July 24, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant