Skip to content

python3Packages.poetry-core: fix build with newer clang#234864

Merged
wegank merged 1 commit intoNixOS:stagingfrom
reckenrode:poetry-clang-fix
May 30, 2023
Merged

python3Packages.poetry-core: fix build with newer clang#234864
wegank merged 1 commit intoNixOS:stagingfrom
reckenrode:poetry-clang-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

@reckenrode reckenrode commented May 29, 2023

Description of changes

Silence an integer conversion warning that newer clangs issue, causing the build to fail.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
python3Packages.poetry-core: fix build with newer clang
db33597 
Silence an integer conversion warning that newer clangs issue, causing
the build to fail.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 29, 2023
@reckenrode reckenrode mentioned this pull request May 29, 2023
Closed
@ofborg ofborg bot requested a review from jonringer May 29, 2023 20:56
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 29, 2023
@wegank
Copy link
Copy Markdown
Member

wegank commented May 30, 2023

An equivalent patch is

  postPatch = ''
    sed -i '13s/NULL/0/' \
      tests/masonry/builders/fixtures/extended/extended/extended.c \
      tests/masonry/builders/fixtures/src_extended/src/extended/extended.c \
      tests/masonry/builders/fixtures/extended_with_no_setup/extended/extended.c
  '';

So indeed, only the tests are affected. We could also send a proper fix upstream.

@wegank wegank closed this May 30, 2023
@wegank wegank reopened this May 30, 2023
@wegank wegank merged commit b3fb622 into NixOS:staging May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reckenrode @wegank