xnu: use python3Minimal instead of python3#234856
Closed
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
Closed
xnu: use python3Minimal instead of python3#234856reckenrode wants to merge 1 commit intoNixOS:stagingfrom
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
Conversation
xnu does not require a Python that supports configd, so use a minimal one without support. Doing this prevents an infinite recuresion when building configd with xpc, which is needed to build with a newer LLVM.
Member
|
The change being in |
Contributor
Author
|
Looks like I might have cherry-picked the wrong commit. Let me dig into this to see what happened and whether this one is even still necessary. |
Contributor
Author
|
I’m not sure what happened here. At one point while working on a configd fix, I ran into an infinite recursion. I thought I modified However, I do have an actual fix for xnu. It fails to build with newer clangs due needing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
xnu does not require a Python that supports configd, so use a minimal one without support. Doing this prevents an infinite recuresion when building configd with xpc, which is needed to build with a newer LLVM.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)