rewrite-tbd: avoid infinite recursion when cmake is not cmakeMinimal#234855
Merged
wegank merged 1 commit intoNixOS:stagingfrom May 31, 2023
Merged
rewrite-tbd: avoid infinite recursion when cmake is not cmakeMinimal#234855wegank merged 1 commit intoNixOS:stagingfrom
wegank merged 1 commit intoNixOS:stagingfrom
Conversation
wegank
reviewed
May 30, 2023
wegank
reviewed
May 30, 2023
This was found while working on the Darwin stdenv rework. This change allows rewrite-tbd to use the provided Makefile instead of depending on cmake and pkg-config. Co-authored-by: Weijia Wang <9713184+wegank@users.noreply.github.com>
b1de0be to
259b15f
Compare
Contributor
Author
|
Thanks for the feedback. I’ve incorporated the changes and squashed the commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This was found while working on the Darwin stdenv rework. This change allows rewrite-tbd to use the provided Makefile instead of depending on cmake and pkg-config.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)