Skip to content

linux.configfile: remove unused kernelTarget attr#234090

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:linux-configfile-kernelTarget
Jun 4, 2023
Merged

linux.configfile: remove unused kernelTarget attr#234090
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:linux-configfile-kernelTarget

Conversation

@alyssais
Copy link
Copy Markdown
Member

Description of changes

As far as I can tell this is unused since f95d214.

Fixes: #234084

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

As far as I can tell this is unused since f95d214.

Fixes: f95d214 ("Implement generic kernel build via manual-config")
Fixes: NixOS#234084
@alyssais alyssais requested a review from Ericson2314 May 25, 2023 22:45
@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label May 25, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels May 25, 2023
@alyssais alyssais merged commit 01b3642 into NixOS:staging Jun 4, 2023
@alyssais alyssais deleted the linux-configfile-kernelTarget branch June 4, 2023 18:38
@ghost ghost mentioned this pull request Jul 28, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant