Skip to content

libudev-zero: fix cross compilation#231992

Merged
alyssais merged 1 commit intomasterfrom
unknown repository
May 15, 2023
Merged

libudev-zero: fix cross compilation#231992
alyssais merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 15, 2023

Description of changes

libudev-zero's Makefile sets AR=ar; we must override this when cross compiling. With this commit, pkgsCross.aarch64-multiplatform.libudev-zero builds.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

libudev-zero's `Makefile` sets `AR=ar`; we must override this when
cross compiling.  With this commit,
`pkgsCross.aarch64-multiplatform.libudev-zero` builds.
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label May 15, 2023
@ofborg ofborg bot requested review from SCOTT-HAMILTON and alyssais May 15, 2023 07:19
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 15, 2023
@alyssais
Copy link
Copy Markdown
Member

@ofborg build pkgsCross.riscv64.libudev-zero

@alyssais alyssais merged commit 8b72abd into NixOS:master May 15, 2023
@ghost ghost deleted the pr/libudev-zero/fixcross branch January 23, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant