Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This brings https://github.com/nix-community/lanzaboote UEFI stub in-tree.
Dependents:
Dependencies:
Related:
Current design
Stub and tool are packaged in the global hierarchy as:
lanzaboote-toolandlanzaboote-uefi-stub, no assumption on the system are encoded inside their package respectively.It is expected to build the UEFI stub using a UEFI system with a UEFI compiler.
The linker is a flavored linker which will propagate adequately the
lldWindows-style driver for arguments.lanzaboote-toolis supposed to be wrapped to know about itslanzaboote-stub, unfortunately, this is impossible to achieve inside of nixpkgs, multiple attempts were proposed to the reviewers in the next section and were all rejected. Therefore, the only solution is to give up on having a wrappedlanzaboote-tooland propose a semi-wrappedlanzaboote-tooland expect the user to understand they have to export theLANZABOOTE_STUBenvironment variable to know about the stub itself.This is what we do in the systemd-boot NixOS module ourselves and we expect to work in many cases, either case, author would like to move this PR forward ideally and not concern themselves further with the semi wrapping issue stemming from the impossibility to build a package as a data via cross-compilation inside of nixpkgs, alas.
What has been tried?
pkgs/hierarchy: NACK because it reimports nixpkgs inside nixpkgs.uefiPkgsfor cross compilation inside nixpkgs without a direct reimport: NACK because it's too complicated and does not compose well.Some funny questions
It seems like this PR tries to move to make UEFI a proper target in nixpkgs, but there's already plenty of "data as UEFI binaries" inside of nixpkgs without any cross compilation involved per se:
Ideally, we should treat the same way as in this PR, I suppose this will be very hard given their build system.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)