dmd: build using gcc11Stdenv#230827
Merged
2 commits merged intomasterfrom May 10, 2023
unknown repository
Merged
Conversation
Member
|
@ofborg build dmd dmd.passthru.tests |
wegank
previously approved these changes
May 9, 2023
wegank
reviewed
May 9, 2023
trofi
approved these changes
May 9, 2023
Contributor
trofi
left a comment
There was a problem hiding this comment.
LGTM, i agree we should not override stdenv at least for darwin.
Without the change autopatchelf fails to find the dependency as:
searching for dependencies of ...-dmd-bootstrap-2.090.1/bin/dmd
libgcc_s.so.1 -> not found!
auto-patchelf: 6 dependencies could not be satisfied
Full build log: https://hydra.nixos.org/log/plma45m19p0cm1i04c4qzmfi54n38ydk-dmd-bootstrap-2.090.1.drv
The DMD test suite has been failing since we updated to gcc12, as reported by @trofi: #206907 (comment) Let's use gcc11Stdenv for now.
Author
|
Squashed (into two commits instead of three), rebased. |
Author
|
Waiting for ofborg-eval to finish, then I will merge this. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The DMD test suite has been failing since we updated to gcc12, as
reported by @trofi:
#206907 (comment)
Let's use gcc11Stdenv for now.
#230712
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)