Skip to content

nootka: use getDev to access .dev attributes#230334

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:nootka-use-getDev
May 6, 2023
Merged

nootka: use getDev to access .dev attributes#230334
trofi merged 1 commit intoNixOS:masterfrom
trofi:nootka-use-getDev

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented May 6, 2023

To allow libjack2 to extract headers to a separare .dev output nootka should refer to it via getDev indirection.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

To allow `libjack2` to extract headers to a separare `.dev` output
`nootka` should refer to it via `getDev` indirection.
@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented May 6, 2023

Result of nixpkgs-review pr 230334 run on x86_64-linux 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 6, 2023
@trofi trofi merged commit 9ce9c29 into NixOS:master May 6, 2023
@trofi trofi deleted the nootka-use-getDev branch May 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant