Skip to content

csound: drop override for JACK_HEADER#230329

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:commit-no-jack-override
May 8, 2023
Merged

csound: drop override for JACK_HEADER#230329
trofi merged 1 commit intoNixOS:masterfrom
trofi:commit-no-jack-override

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented May 6, 2023

The header works as is without the override.

diffoscope shows no difference before and after on x86_64-linux.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The header works as is without the override.

`diffoscope` shows no difference before and after on x86_64-linux.
@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented May 6, 2023

Result of nixpkgs-review pr 230329 run on x86_64-linux 1

5 packages built:
  • csound
  • csound-qt
  • faust2csound
  • liquidwar
  • solfege

@ofborg ofborg bot requested a review from MarcWeber May 6, 2023 13:01
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 6, 2023
@trofi trofi merged commit db82126 into NixOS:master May 8, 2023
@trofi trofi deleted the commit-no-jack-override branch May 8, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant