haskellPackages.streamly-archive: unbreak#229443
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom May 2, 2023
Merged
haskellPackages.streamly-archive: unbreak#229443maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
Member
|
Thank you! Sorry for the problems with the regenerate script. I am kind-of iterating on that one at the moment. Can you add a comment that streamly-archive only works with streamly >= 0.9.0. The perfect solution would actually be an assert on the version of Also, you might want to add yourself as maintainer of streamly-archive so that the package won’t break silently in the future. |
Contributor
Author
|
Thanks! I have now made the suggested changes. Edit: Adding myself as maintainer here: #229459 |
Member
|
Excellent! Sadly, merging your other PR caused a merge conflict. Can you resolve that? Then I can merge this. |
Contributor
Author
|
Sure, we can try again now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix-build --no-out-link -A haskellPackages.streamly-archive --arg config '{ allowBroken = true; }'maintainers/scripts/haskell/regenerate-hackage-packages.sh --fastand included the result in the PR. (Running this without--fastyielded arm: cannot remove 'transitive-broken.ZwXjyKT': No such file or directoryerror, and resulted in a few changes totransitive-broken.yamlthat had nothing to do withstreamly-archive.)