cross bootstrap stdenvs: fix build#228130
Closed
GenericNerdyUsername wants to merge 1 commit intoNixOS:masterfrom
Closed
cross bootstrap stdenvs: fix build#228130GenericNerdyUsername wants to merge 1 commit intoNixOS:masterfrom
GenericNerdyUsername wants to merge 1 commit intoNixOS:masterfrom
Conversation
ghost
reviewed
Apr 26, 2023
ghost
left a comment
There was a problem hiding this comment.
Please fix the subject line to follow the commit message format. Otherwise @zowoq will give me grief.
Please also put something in the commit message body about what was failing and why this fixes it. You can copy and paste the build failure from here: https://hydra.nixos.org/build/215849262/nixlog/32/tail if you like.
This was most likely broken by #209870 which switched from using statically-linked libisl to normal dynamically-linked libisl. We should make sure we're putting the correct one into the bootstrapFiles. I'm not sure this commit does that. I will investigate more closely but don't have time to do that today.
16 tasks
|
Please use this instead: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
All arches in
nix-build pkgs/top-level/release-cross.nix -A bootstrapTools.[arch].build --arg supportedSystems '[builtins.currentSystem]', with the exception ofmips64el-linux-gnuabin32, should build nowThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)