system.boot.kernel: warn about requiredKernelConfig limitations#228000
Conversation
I struggled a lot before realizing that system.boot.kernel.requiredKernelConfig was not only being ignored (due to kernel?features) but wasn't even really checking my requirements against the true kernel configuration. This commit updates the option documentation to warn others of the limitations I discovered. Long-term we should probably either remove this option or else have it check the requirements against the true, final `.config` that was used to build the kernel.
Member
|
I dreamt at some point of being able to check the kernel config against requiredKernelConfig and requiredKernelConfig being loaded from analyzing the installed derivations but options change names between kernel releases (sometimes) and this is hard to check anyway between programs requiring an option as module etc. It would still be valuable IMO in the "meta" attribute of derivations. |
Author
That's okay! You want a failure when that happens in order to let you know that you need to update the |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I struggled a lot before realizing that
system.boot.kernel.requiredKernelConfigwas not only being ignored (due tokernel?features) but wasn't even really checking my requirements against the true kernel configuration.This commit updates the option documentation to warn others of the limitations I discovered.
Long-term we should probably either remove this option or else have it check the requirements against the true, final
.configthat was used to build the kernel.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)