Skip to content

pyqt5: add enableVerbose?false#227898

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

pyqt5: add enableVerbose?false#227898
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 24, 2023

Description of changes

The build logs from PyQT5 are quite verbose; it's nice to trim them down so all you see is the errors. This commit adds an option which does that. It also adds "-w" to NIX_CFLAGS_COMPILE in non-verbose builds, because newer compilers keep piling on the warnings and Qt5 isn't getting updates.

Gee I wish this package could use more than one core when building.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 24, 2023
@ofborg ofborg bot requested a review from svanderburg April 24, 2023 00:23
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 24, 2023
The build logs from PyQT5 are quite verbose; it's nice to trim them
down so all you see is the errors.  This commit adds an option which
does that.  It also adds "-w" to `NIX_CFLAGS_COMPILE` in non-verbose
builds, because newer compilers keep piling on the warnings and Qt5
isn't getting updates.
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 12, 2023

Rebased.

@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/pyqt5/verbose branch October 22, 2023 05:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants