haskellPackages.gio & haskellPackages.gtk Fixes#227690
Merged
maralorn merged 3 commits intoNixOS:haskell-updatesfrom Apr 23, 2023
Merged
haskellPackages.gio & haskellPackages.gtk Fixes#227690maralorn merged 3 commits intoNixOS:haskell-updatesfrom
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
Conversation
Contributor
Author
|
hold on, building |
Member
|
@hellwolf When you figure out your problem, make sure to also base this on the |
Contributor
Author
Sure done. I am wondering, if there is already other attempt of fixing the gtk package? It seems an important one? |
Contributor
Author
|
fwiw: |
Contributor
Author
|
Found a way to fix gtk. The usage of Also what do you think of the usage of |
sternenseemann
requested changes
Apr 23, 2023
Member
sternenseemann
left a comment
There was a problem hiding this comment.
Would be nice if you could split the refactoring and the change into separate commits for review.
Also commit message of haskellPackages.gio: … etc. is more appropriate since this change affects all package sets. I also hope you have tested this in other (at least the main) package set(s).
Member
|
@ofborg build haskellPackages.gio haskellPackages.gtk |
Contributor
Author
Done. Separated in two two commit, and all tested with ghc92, ghc94. With ghc96, haskellPackages.glib fails too. |
Member
|
This looks good to me, and building
|
Contributor
Author
check it out again. |
- using lib.pipe
- More addPkgconfigDepends - Tested pkgsets: - [x] .#haskell.packages.ghc92.gio - [x] .#haskell.packages.ghc94.gio
Member
|
Sorry, forgot this earlier, but I have one last change request. The |
- More addPkgconfigDepends - doJailbreak - Tested pkgsets: - [x] .#haskell.packages.ghc92.gtk - [x] .#haskell.packages.ghc94.gtk
Contributor
Author
done! |
Member
|
Excellent! |
Member
|
Just realized that this PR breaks eval on darwin because of the selinux dependency. |
Contributor
Author
|
oh shoot, would disable selinux for gtk on darwin work? |
Member
|
I fixed it with f7e7809 but this feels a bit fishy. It’s unclear to me whether all those overrides are needed on all plattforms. |
Contributor
Author
Agreed. I had to manually add them because of the builds fail on my x86_64-linux environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The haskell.packages.ghc94.gio fails to build, affecting packages that relies on it.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)