rust/cargo.nix: fix pkgsCross.*.cargo again#227683
Merged
Conversation
added 2 commits
April 22, 2023 12:56
Not much point in auditing things that can't be built.
12 tasks
Author
|
@ofborg build pkgsCross.aarch64-multiplatform.cargo |
figsoda
reviewed
Apr 22, 2023
figsoda
reviewed
Apr 22, 2023
Prior to this commit, builds of `pkgsCross.aarch64-multiplatform.cargo` would fail due to being unable to find `-lz` when compiling cargo's own `build.rs` for the `buildPlatform`. This environment variable uses the (very confusing) LLVM convention of calling the buildPlatform "HOST". Co-authored-by: figsoda <figsoda@pm.me>
Author
|
Squashed. |
figsoda
approved these changes
Apr 22, 2023
|
Hello! Author of Cross-compilation is implemented; if it doesn't work, that's a serious bug. Could you post a command reproducing the issue with Ideally I'd also like to track it as a github issue, but I can file that myself. |
Member
|
This could just be an issue with the packaging, I will take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Cross-compilation of
cargohas regressed due to two issues:Since rustPlatform.buildRustPackage: make auditable the default #223320 builds fail because
cargo-auditabledoes not cross compile. This PR fixes the regression by keeping the previousaudit=falsedefault on cross builds until someone fixescargo-auditable.Recently our
cargo.nixforgot how to locate thebuildPlatform'slibz.so. In order to remind it, this PR setsHOST_PKG_CONFIG_PATHfor cross-compiled builds.After this PR,
pkgsCross.aarch64-multiplatform.cargoshould build again.Things done
x86_64-linux)Not much point in auditing things that can't be built.