haskell.packages.text-time: remove broken attribute#227620
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Apr 22, 2023
Merged
haskell.packages.text-time: remove broken attribute#227620maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
Member
|
But the package set we curate is for ghc 9.2. We should either make sure the package builds on ghc 9.2, or we only mark it as unbroken on 9.6. |
Contributor
Author
|
It seems like the latest version also works with ghc92, e.g. this worked: |
Member
|
By the way, I just build |
Member
|
Jep, builds. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The latest text-time version builds with:
(import ./. {}).haskell.packages.ghc961.ghcWithPackages (p: [ p.text-time ])Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)