Skip to content

Haskell updates examples#227583

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
thielema:haskell-updates-examples
Apr 22, 2023
Merged

Haskell updates examples#227583
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
thielema:haskell-updates-examples

Conversation

@thielema
Copy link
Copy Markdown
Contributor

Description of changes

haskellPackages: add buildExamples Cabal flag to audacity, med-module, spreadsheet

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@thielema thielema changed the base branch from master to haskell-updates April 22, 2023 10:37
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 22, 2023
@thielema thielema force-pushed the haskell-updates-examples branch from 4dfc710 to 71db085 Compare April 22, 2023 10:38
@maralorn
Copy link
Copy Markdown
Member

Cool.

We have one subtle distinction, though. configuration-common.nix contains overrides which fix the current version of packages. configuration-nix.nix contain overrides which are generally needed to build packages and not considered temporary fixes.

So these overrides belong in the other file, sorry.

@thielema thielema force-pushed the haskell-updates-examples branch from 71db085 to fa0a071 Compare April 22, 2023 10:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2023
@maralorn
Copy link
Copy Markdown
Member

Excellent!

@maralorn maralorn merged commit 4c3eb38 into NixOS:haskell-updates Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants