qemu: allow to disable generation of documentation#227477
Merged
Conversation
Artturin
reviewed
Apr 21, 2023
I've been having trouble with some qemu builds since the v8.0.0 bump failing with: ``` kernel-doc 'perl /build/qemu/docs/../scripts/kernel-doc -rst -enable-lineno -sphinx-version 5.3.0 -Werror /build/qemu/docs/../include/qemu/bitops.h' processing failed with: [Errno 2] No such file or directory: 'perl' ``` ... this happens despite `perl` being part of `stdenv`. Adding `perl` to `nativeBuildInputs` doesn't seem to fix it. It is handy to be able to simply skip the docs in situations like this in order to maintain forward progress, so this commit adds `enableDocs?true` to allow that.
45M -> 31M
Artturin
approved these changes
Apr 21, 2023
Member
Artturin
left a comment
There was a problem hiding this comment.
reduces the size of qemu-user from 45M -> 31M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I've been having trouble with some qemu builds since the v8.0.0 bump failing with:
... this happens despite
perlbeing part ofstdenv. AddingperltonativeBuildInputsdoesn't seem to fix it. It is handy to be able to simply skip the docs in situations like this in order to maintain forward progress, so this commit addsenableDocs?trueto allow that.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)