uhd: Better cross compilation support#226676
Merged
doronbehar merged 4 commits intoNixOS:masterfrom Apr 21, 2023
Merged
Conversation
bjornfor
approved these changes
Apr 17, 2023
Contributor
bjornfor
left a comment
There was a problem hiding this comment.
Nit: Please write in revert commits why they are reverted. (Yes, it's documented in github, but not as straight forward to spot when viewing git log.)
This reverts commit ec1631a. It was merged too fast, without giving a chance to maintainers to suggest the changes in the upcoming commits.
79faa0b to
2566506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This reverts commit ec1631a from #226558, and helps cross compilation differently.
I tested this with:
And checked that there are no references to
buildPackages.python3via:Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)