Skip to content

abiword: fix cross#226557

Merged
NickCao merged 2 commits intomasterfrom
unknown repository
Apr 18, 2023
Merged

abiword: fix cross#226557
NickCao merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 17, 2023

Description of changes

This commit adds perl to nativeBuildInputs of abiword, to avoid
the following build failure:

abiword-aarch64-unknown-linux-gnu> checking for perl... no
abiword-aarch64-unknown-linux-gnu> configure: error: *** perl program not found
error: build of '/nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv' on 'ssh://root@192.168.22.102' failed: builder for '/nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv' failed with exit code 1
error: builder for '/nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv' failed with exit code 1;
       last 10 log lines:
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 PIC flag -fPIC -DPIC works... yes
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 static flag -static works... no
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 supports -c -o file.o... yes
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 supports -c -o file.o... (cached) yes
       > checking whether the aarch64-unknown-linux-gnu-g++ -std=c++11 linker (aarch64-unknown-linux-gnu-ld) supports shared libraries... yes
       > checking dynamic linker characteristics... (cached) GNU/Linux ld.so
       > checking how to hardcode library paths into programs... immediate
       > checking whether ln -s works... yes
       > checking for perl... no
       > configure: error: *** perl program not found
       For full logs, run 'nix log /nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv'.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 17, 2023
@ofborg ofborg bot requested a review from pSub April 17, 2023 01:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 17, 2023
Adam Joseph added 2 commits April 17, 2023 19:59
This commit adds `perl` to `nativeBuildInputs` of abiword, to avoid
the following build failure:

```
abiword-aarch64-unknown-linux-gnu> checking for perl... no
abiword-aarch64-unknown-linux-gnu> configure: error: *** perl program not found
error: build of '/nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv' on 'ssh://root@192.168.22.102' failed: builder for '/nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv' failed with exit code 1
error: builder for '/nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv' failed with exit code 1;
       last 10 log lines:
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 PIC flag -fPIC -DPIC works... yes
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 static flag -static works... no
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 supports -c -o file.o... yes
       > checking if aarch64-unknown-linux-gnu-g++ -std=c++11 supports -c -o file.o... (cached) yes
       > checking whether the aarch64-unknown-linux-gnu-g++ -std=c++11 linker (aarch64-unknown-linux-gnu-ld) supports shared libraries... yes
       > checking dynamic linker characteristics... (cached) GNU/Linux ld.so
       > checking how to hardcode library paths into programs... immediate
       > checking whether ln -s works... yes
       > checking for perl... no
       > configure: error: *** perl program not found
       For full logs, run 'nix log /nix/store/v670j4pyqk5vy625gh7w0j2jla1wrz2s-abiword-aarch64-unknown-linux-gnu-3.0.5.drv'.
```
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 18, 2023

Squashing...

Copy link
Copy Markdown
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 226557 run on x86_64-linux 1

1 package built:
  • abiword

And pkgsCross.aarch64-multiplatform.abiword builds.

@NickCao NickCao merged commit ab809f2 into NixOS:master Apr 18, 2023
@ghost ghost deleted the pr/fixcross/abiword branch April 20, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant