Skip to content

gpgme: fix cross, drop python2#226123

Merged
dotlambda merged 1 commit intomasterfrom
unknown repository
Apr 15, 2023
Merged

gpgme: fix cross, drop python2#226123
dotlambda merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 14, 2023

This package very confusingly takes both python(2) and python3 as
arguments, and then mixes them up via an overlay in python-packages.
Since python2 is now marked INSECURE, let's just stick with python3.

Also fixes cross compilation.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 14, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 14, 2023
@ofborg ofborg bot requested a review from dotlambda April 14, 2023 07:34
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 14, 2023
Mindavi
Mindavi reviewed Apr 14, 2023
View reviewed changes
pkgs/development/libraries/gpgme/default.nix Outdated
Copy link
Copy Markdown
Contributor

@Mindavi Mindavi Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in depsBuildBuild instead then?

Copy link
Copy Markdown
Contributor

@Mindavi Mindavi Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's not spliced :/

Copy link
Copy Markdown
Author

@ghost ghost Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whole splicing thing needs to be rethought/redone.

dotlambda
dotlambda requested changes Apr 14, 2023
View reviewed changes
@dotlambda
Copy link
Copy Markdown
Member

dotlambda commented Apr 14, 2023

takes both python(2) and python3

It takes null because python is an alias or maybe not even that anymore.

@ghost ghost requested a review from dotlambda April 14, 2023 17:29
dotlambda
dotlambda requested changes Apr 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash.

gpgme: fix cross, drop python2
08c78ea 
This package very confusingly takes both python(2) and python3 as
arguments, and then mixes them up via an overlay in python-packages.
Since python2 is now marked INSECURE, let's just stick with python3.

Also fixes cross compilation.
@ghost ghost requested a review from dotlambda April 14, 2023 18:33
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 14, 2023

Please squash.

Done.

@dotlambda dotlambda merged commit b564f80 into NixOS:master Apr 15, 2023
@ghost ghost deleted the pr/fixcross/gpgme branch April 15, 2023 17:54
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
@Sigmanificient
Copy link
Copy Markdown
Member

Sigmanificient commented Jan 14, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotlambda @Sigmanificient @Mindavi