Skip to content

nixos/sslh: fix default config#225602

Closed
symphorien wants to merge 1 commit intoNixOS:masterfrom
symphorien:sslh_config_type
Closed

nixos/sslh: fix default config#225602
symphorien wants to merge 1 commit intoNixOS:masterfrom
symphorien:sslh_config_type

Conversation

@symphorien
Copy link
Copy Markdown
Member

sslh only warns when a config parameter does not exist or has the wrong type so such mistakes can easily go unnoticed

Fixes #225454

@VAWVAW please test

@GrahamcOfBorg test sslh

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

sslh only warns when a config parameter does not exist or has the wrong
type so such mistakes can easily go unnoticed

Fixes NixOS#225454
@symphorien symphorien changed the title nixos/ssl: fix default config nixos/sslh: fix default config Apr 10, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 10, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 10, 2023
@symphorien symphorien closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sslh: invalid configuration options

1 participant