Conversation
Adapted from Void Linux commit 81c3c1884be1959337b55cd88d4748d17ac6c3de.
|
Rebased. |
doronbehar
left a comment
There was a problem hiding this comment.
Lastly, https://github.com/NixOS/nixpkgs/pull/225111#discussion_r1160513273 is not a good commit message :)
| substituteInPlace configure \ | ||
| --replace 'pkg-config' "${buildPackages.pkg-config}/bin/${buildPackages.pkg-config.targetPrefix}pkg-config" | ||
| substituteInPlace configure \ | ||
| --replace './_check_x509_validity' 'true' | ||
| substituteInPlace configure \ | ||
| --replace './_check_session_keys' 'true' |
There was a problem hiding this comment.
Nit: You can do it all in a single substituteInPlace command.
| }) | ||
| ]; | ||
|
|
||
| XAPIAN_CONFIG = "${xapian}/bin/xapian-config"; |
There was a problem hiding this comment.
This doesn't seem like it would behave well in a cross compilation...
| ++ lib.optional withSfsexp sfsexp; | ||
|
|
||
| patches = [ | ||
| (fetchpatch { |
There was a problem hiding this comment.
Too bad upstream uses mailing lists for tracking development... I know its a lot to ask, but are you aware of any attempts to tell them about these issues? It'd be nice to add some comment just in case.
| pythonPackages.sphinx # (optional) documentation -> doc/INSTALL | ||
| texinfo # (optional) documentation -> doc/INSTALL | ||
| pythonPackages.cffi | ||
| gnupg |
There was a problem hiding this comment.
Are you sure the gnupg and perl in buildInputs are still needed?
| cp notmuch-git $out/bin/notmuch-git | ||
| wrapProgram $out/bin/notmuch-git --prefix PATH : $out/bin:${lib.getBin git}/bin | ||
| '' + '' | ||
| mkdir -p $info |
There was a problem hiding this comment.
Why is this needed all of a sudden?
Adapted from Void Linux commit 81c3c1884be1959337b55cd88d4748d17ac6c3de and f95b944252e3a1fc900a18c8eeed59e6de9b6e9a.
Note:
withEmacswill be disabled automatically due to