stdenv: fix pkgsMusl#224947
Conversation
|
@ofborg build pkgsMusl.stdenv |
|
ofborg says: pkgsMusl.stdenv on x86_64-linux — Success |
trofi
left a comment
There was a problem hiding this comment.
Yeah, wrong libstdc++ sounds problematic. static-libstdc++ should be fine as a short-term workaround.
|
Is there any way we could get this to not cause any rebuilds for non-musl, so we can get it into staging-next? If we just merge this into staging now, we'll have a cycle where musl is completely broken. (We can then immediately remove any musl conditional we don't want to keep on staging, to keep the code clean.) |
Let me see. |
|
So it turns out this can be separated from #224945 , which is what causes the rebuilds. Verifying that it still works... |
|
@ofborg build pkgsMusl.stdenv |
I broke `pkgsMusl` with #209870. Something odd is happening with `xgcc` (the temporary compiler that should be used only to compile `gcc`, although we are using it to compile a temporary `patchelf` too) and `libstdc++`. The temporary fix in this commit is to use `-static-libstdc++` for the ephemeral `patchelf` built by `xgcc`. It isn't pretty, but it appears to work. Incorporates: - #224945
|
Rebased to @ofborg build pkgsMusl.stdenv |
|
OfBorg looks like it had a networking hiccup on aarch64-linux, but I built pkgsMusl.stdenv successfully on the community builder. |
Description of changes
I broke
pkgsMuslwith #209870.Something odd is happening with
xgcc(the temporary compiler that should be used only to compilegcc, although we are using it to compile a temporarypatchelftoo) andlibstdc++.The temporary fix in this commit is to use
-static-libstdc++for the ephemeralpatchelfbuilt byxgcc. It isn't pretty, but it appears to work.I'm starting to think we shouldn't even be trying to recompile
patchelfuntil we build the finalgcc. But that is too big of a change to be making this close to ZHF.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)