zathura: disable tests if cross#224903
Merged
1 commit merged intomasterfrom Apr 24, 2023
unknown repository
Merged
Conversation
Author
|
@ofborg build pkgsCross.aarch64-multiplatform.zathura |
Contributor
|
Since this changes nothing for native builds, but at least builds for aarch64 on x86-64 (tested with #224901), I'm not opposed to merging this, but I'd strongly prefer fixing the stuff that does not work over disabling it:
|
Author
Done: 20860bf1129d1290de20bf378968720ce1105fb1 Note: it's easier to keep track of requests like this if you leave them as resolvable review comments.
I left a review. |
apfelkuchen6
reviewed
Apr 6, 2023
Author
|
If ofborg is successful with the two builds I asked it to do in #223303, I adjust this PR to keep texlive for cross builds. |
Artturin
reviewed
Apr 7, 2023
Author
|
Squashing... |
Author
|
@ofborg build pkgsCross.aarch64-multiplatform.zathura |
Artturin
reviewed
Apr 22, 2023
Artturin
approved these changes
Apr 22, 2023
Author
The only part of zathura that won't cross compile is the tests. Let's disable these so the binaries at least can be cross-built. This commit also adds `check` to `buildInputs` and fixes the reference to `sphinx`. Co-authored-by: apfelkuchen6 <73002165+apfelkuchen6@users.noreply.github.com> Co-authored-by: Artturi <Artturin@artturin.com>
Author
|
@ofborg build pkgsCross.aarch64-multiplatform.zathura |
Author
|
Rebased, no other changes. @ofborg build pkgsCross.aarch64-multiplatform.zathura |
Author
|
Ah right, this won't cross-build on |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only part of zathura that won't cross compile is the documentation and tests. Also, the dependency for synctex support (texlive) doesn't cross compile.