WIP: python3Packages.openai-triton: make cudaSupport optional#224898
WIP: python3Packages.openai-triton: make cudaSupport optional#224898SomeoneSerge wants to merge 13 commits intoNixOS:masterfrom
Conversation
…with cuda-compatible stdenv
catch up with pytorch 2.0.0 and updated interfaces
The drawback of this is that the comments now affect outPath's. Hopefully, though, we'll remove this preFixup soon anyway Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
…atoolkit-vendored copy of the library
| , cmake | ||
| , config | ||
| , cudaPackages ? { } | ||
| , cudaSupport ? config.cudaSupport or false |
There was a problem hiding this comment.
Can you define this as a proper option in the file that describes the config attr? Then we also have a default false
There was a problem hiding this comment.
Oh, so config already supports options?!!
There was a problem hiding this comment.
Looking at pkgs/top-level/config.nix for the first time now. This is great, I really needed this, our cudaCapabilities and cudaSupport are already a mess, and we still need more controls (virtual vs real architectures, default mkl support)
There was a problem hiding this comment.
We'll have a separate PR for config.nix integration
There was a problem hiding this comment.
Oh, so
configalready supports options?!!
It does since ~4 years but people only really started using it a year ago. Glad that that helps you.
|
@SomeoneSerge Now that rocfft builds on hydra this would be great to have |
Description of changes
TBD. Follow-up to #222273
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)