systemdMinimal: re-enable kmod integration#224421
Closed
software-artificer wants to merge 1 commit intoNixOS:masterfrom
Closed
systemdMinimal: re-enable kmod integration#224421software-artificer wants to merge 1 commit intoNixOS:masterfrom
software-artificer wants to merge 1 commit intoNixOS:masterfrom
Conversation
My previous attempt to slim things down for systemdMinimal ended up breaking the Mobile NixOS use case, as it uses udevd from the systemdMinimal package. Re-enabling the `withKmod` attribute to address this problem.
12 tasks
49 tasks
Member
|
Needs to target staging |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
My previous attempt to slim things down for systemdMinimal in #217249 ended up breaking the Mobile NixOS use case, as it uses udevd from the systemdMinimal package. Re-enabling the
withKmodattribute to address this problem. Thanks @lheckemann for point this out 🙇🏻♂️Things done
For non-Linux: Isusing NixOSsandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)