Skip to content

gpgme: enableParallelBuilding=true#223663

Merged
Artturin merged 1 commit intostagingfrom
unknown repository
Apr 13, 2023
Merged

gpgme: enableParallelBuilding=true#223663
Artturin merged 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 28, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from dotlambda March 28, 2023 23:35
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 29, 2023
Copy link
Copy Markdown
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to go to staging

@ghost ghost marked this pull request as draft April 5, 2023 08:21
@ghost ghost changed the base branch from master to staging April 5, 2023 08:22
@ghost ghost marked this pull request as ready for review April 5, 2023 08:24
@ghost ghost requested a review from dotlambda April 5, 2023 08:24
@Artturin
Copy link
Copy Markdown
Member

No failures with repeat 10 nix build ".#gpgme" --rebuild --cores 24

1m 5s -> 33s

@Artturin Artturin merged commit a288d73 into NixOS:staging Apr 13, 2023
@ghost ghost deleted the pr/gpgme/enableParallelBuilding2 branch April 13, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants