Skip to content

lua*Packages: fix the default namePrefix as intended#223349

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
vcunat:p/lua-name-prefix
Mar 29, 2023
Merged

lua*Packages: fix the default namePrefix as intended#223349
vcunat merged 1 commit intoNixOS:stagingfrom
vcunat:p/lua-name-prefix

Conversation

@vcunat
Copy link
Copy Markdown
Member

@vcunat vcunat commented Mar 27, 2023

It was based on version of the package and not the interpreter 🤦🏽

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label Mar 27, 2023
@vcunat vcunat mentioned this pull request Mar 27, 2023
Merged
12 tasks
vcunat referenced this pull request Mar 27, 2023
@SuperSandro2000
interpreters/lua: replace sourceVersion with lib.versions
b374880
@vcunat vcunat mentioned this pull request Mar 27, 2023
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 27, 2023
@vcunat vcunat changed the base branch from master to staging March 27, 2023 07:36
@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Mar 27, 2023

This doesn't seem urgent, so staging should good enough. Rebuild count isn't low, even though it probably wouldn't be expensive really.

SuperSandro2000
SuperSandro2000 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 upsi, thanks for cleaning up after me

@figsoda figsoda added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 27, 2023
@vcunat vcunat merged commit 8bb1d31 into NixOS:staging Mar 29, 2023
@vcunat vcunat deleted the p/lua-name-prefix branch March 29, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teto teto teto approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vcunat @teto @SuperSandro2000 @figsoda