Skip to content

gpgme: 1.18.0 -> 1.19.0#222443

Merged
lovesegfault merged 1 commit intoNixOS:stagingfrom
dotlambda:gpgme-1.19.0
Mar 28, 2023
Merged

gpgme: 1.18.0 -> 1.19.0#222443
lovesegfault merged 1 commit intoNixOS:stagingfrom
dotlambda:gpgme-1.19.0

Conversation

@dotlambda
Copy link
Copy Markdown
Member

@dotlambda dotlambda commented Mar 22, 2023

Description of changes

Changelog: https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;f=NEWS;hb=gpgme-1.19.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @sg2002

@dotlambda dotlambda requested review from a user, fabaff, misuzu and vcunat March 22, 2023 00:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 22, 2023
@dotlambda dotlambda changed the base branch from master to staging March 22, 2023 01:04
@vcunat vcunat removed their request for review March 22, 2023 08:10
ghost
ghost approved these changes Mar 24, 2023
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, built on

  • x86-64-linux
  • powerpc64le-linux
  • mips64el-linux-gnuabi64 (cross from 86-64-linux)
  • aarch64-linux (cross from x86-64-linux)

@ghost ghost mentioned this pull request Mar 24, 2023
Closed
4 tasks
@figsoda figsoda added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 27, 2023
@lovesegfault lovesegfault self-requested a review March 28, 2023 11:36
@lovesegfault lovesegfault merged commit 9af678b into NixOS:staging Mar 28, 2023
@dotlambda dotlambda deleted the gpgme-1.19.0 branch March 28, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misuzu misuzu misuzu approved these changes

@fabaff fabaff Awaiting requested review from fabaff

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @misuzu @lovesegfault @figsoda