Skip to content

unbound: enable parallel building#222251

Closed
azahi wants to merge 1 commit intoNixOS:stagingfrom
azahi:unbound-parallel-building
Closed

unbound: enable parallel building#222251
azahi wants to merge 1 commit intoNixOS:stagingfrom
azahi:unbound-parallel-building

Conversation

@azahi
Copy link
Copy Markdown
Member

@azahi azahi commented Mar 20, 2023 •
edited
Loading

Description of changes

Add enableParallelBuilding. Shaves 50% off compile time for me.

enableParallelBuilding = false;
real    2m3.553s
user    0m2.874s
sys     0m1.141s

enableParallelBuilding = true;
real    1m17.870s
user    0m0.226s
sys     0m0.456s
Things done
  • Built on platform(s)
    • x86_64-linux (with pkgsStatic)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@azahi azahi force-pushed the unbound-parallel-building branch from 12e7f89 to 2c0078e Compare March 20, 2023 21:15
@azahi azahi changed the title unboud: enable parallel building unbound: enable parallel building Mar 20, 2023
@ofborg ofborg bot requested a review from ajs124 March 20, 2023 22:51
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 20, 2023
@ajs124
Copy link
Copy Markdown
Member

ajs124 commented Mar 21, 2023

this should go through staging

@azahi azahi changed the base branch from master to staging March 21, 2023 10:23
@azahi azahi requested a review from a user March 21, 2023 10:23
@github-actions github-actions bot added 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: kernel The Linux kernel 6.topic: nim Nim programing language labels Mar 21, 2023
@github-actions github-actions bot removed 6.topic: kernel The Linux kernel 6.topic: vim Advanced text editor 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: documentation This PR adds or changes documentation 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: changelog This PR adds or changes release notes 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: nim Nim programing language labels Mar 21, 2023
@azahi
Copy link
Copy Markdown
Member Author

azahi commented Mar 21, 2023

Switched to staging. Sorry for everyone who got pinged. I hate GitHub.

@piegamesde
Copy link
Copy Markdown
Member

piegamesde commented Mar 21, 2023

Please reopen a new PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azahi @ajs124 @piegamesde