Skip to content

v4l-utils: move wrapQtAppsHook to buildInputs#220431

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

v4l-utils: move wrapQtAppsHook to buildInputs#220431
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 10, 2023

wrapQtAppsHook is currently in nativeBuildInputs, which causes it to
attempt to use the buildPlatform's QT libraries. Let's fix cross by
moving it to buildInputs.

wrapQtAppsHook is currently in nativeBuildInputs, which causes it to
attempt to use the buildPlatform's QT libraries.  Let's fix cross by
moving it to buildInputs.
@ghost ghost mentioned this pull request Mar 10, 2023
@ofborg ofborg bot requested a review from codyopel March 10, 2023 04:11
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 10, 2023
@Artturin
Copy link
Copy Markdown
Member

hooks should go in nativeBuildInputs so this is a bug somewhere else

perhaps here

propagatedBuildInputs = [ self.qtbase.dev buildPackages.makeWrapper ]
++ lib.optional stdenv.isLinux self.qtwayland.dev;

https://github.com/NixOS/nixpkgs/blob/master/doc/builders/special/makesetuphook.section.md

@Artturin Artturin marked this pull request as draft March 10, 2023 17:57
@Artturin
Copy link
Copy Markdown
Member

#220518

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 8, 2023

Yeah this PR is definitely broken.

@ghost ghost closed this Apr 8, 2023
@ghost ghost deleted the pr/qt/cross/v4l branch January 23, 2024 06:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant