Skip to content

qt5/qtwebchannel.nix: omit $bin output if cross#220316

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

qt5/qtwebchannel.nix: omit $bin output if cross#220316
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 9, 2023

Description of changes

QtWebChannel does not produce binaries when it is cross-compiled. Let's omit the $bin output in that case.

QtWebChannel does not produce binaries when it is cross-compiled.
Let's omit the `$bin` output in that case.
@ghost ghost requested a review from ttuegel as a code owner March 9, 2023 09:52
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Mar 9, 2023
@ghost ghost mentioned this pull request Mar 9, 2023
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 9, 2023
@Artturin
Copy link
Copy Markdown
Member

there's no binaries in $bin even when not cross-compiling

so these files aren't created when cross-compiling

$ tree ./result-bin
./result-bin
└── lib
    └── qt-5.15.8
        └── qml
            └── QtWebChannel
                ├── libdeclarative_webchannel.so
                ├── plugins.qmltypes
                └── qmldir

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 11, 2023

Let me clarify: QtWebChannel does not produce anything at all in $bin when cross-compiling.

This causes Nix to reject the build because the builder failed to create an expected output.

@Artturin
Copy link
Copy Markdown
Member

Let me clarify: QtWebChannel does not produce anything at all in $bin when cross-compiling.

i understood that but why are qml files not generated when cross-compiling

plugins.qmltypes has this comment

// This file was auto-generated by:
// 'qmlplugindump -nonrelocatable -dependencies dependencies.json QtWebChannel 1.15'

qmlplugindump is in qtdeclarative which is in qtInputs which is propagatedBuildInputs in qtModule so the issue may be fixed by adding qtdeclarative to nativeBuildInputs

@SuperSandro2000
Copy link
Copy Markdown
Member

If there are no files in $out/bin why do we even have the bin output? The files seem to be wrong there in the first place.

@ghost ghost marked this pull request as draft March 21, 2023 03:15
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 21, 2023

I will investigate.

It might be a week or two before I have time to return to this qt5-cross stuff, but I will get to it. Native-compiling stuff on my laptop is too painful.

@ghost ghost marked this pull request as ready for review June 21, 2023 05:15
@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/qt5/cross/qtwebchannel-omit-bin branch October 22, 2023 05:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants