Skip to content

qt-5/modules/qtbase.nix: omit --host and --build configureFlags#220315

Closed
ghost wants to merge 1 commit intostagingfrom
unknown repository
Closed

qt-5/modules/qtbase.nix: omit --host and --build configureFlags#220315
ghost wants to merge 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 9, 2023

Description of changes

QT's configure script doesn't understand these, so let's not pass them.

@ghost ghost requested a review from ttuegel as a code owner March 9, 2023 09:49
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Mar 9, 2023
@ghost ghost mentioned this pull request Mar 9, 2023
Open
@ofborg ofborg bot requested review from bkchr, periklis and qknight March 9, 2023 11:55
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 9, 2023
@Artturin
Copy link
Copy Markdown
Member

Artturin commented Mar 10, 2023

should target staging

@ghost ghost marked this pull request as draft March 11, 2023 04:57
@ghost ghost changed the base branch from master to staging March 11, 2023 04:57
@ghost ghost marked this pull request as ready for review March 11, 2023 04:57
SuperSandro2000
SuperSandro2000 reviewed Mar 18, 2023
View reviewed changes
@ghost ghost marked this pull request as draft April 24, 2023 02:17
@ghost ghost marked this pull request as ready for review June 21, 2023 05:14
@ghost ghost mentioned this pull request Jul 26, 2023
Draft
12 tasks
@OPNA2608 OPNA2608 mentioned this pull request Aug 14, 2023
Merged
12 tasks
@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 17, 2023

Squashed, rebased.

@SuperSandro2000
qt-5/modules/qtbase.nix: omit --host and --build configureFlags
9480cc2 
QT's configure script doesn't understand these, so let's not pass them.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@ofborg ofborg bot added 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 17, 2023
@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/qt5/cross/omit-platforms branch October 22, 2023 05:39
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@periklis periklis Awaiting requested review from periklis

@qknight qknight Awaiting requested review from qknight

@bkchr bkchr Awaiting requested review from bkchr

Assignees

No one assigned

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Artturin @SuperSandro2000