Skip to content

qt-5: add perl to nativeBuildInputs where required#220287

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

qt-5: add perl to nativeBuildInputs where required#220287
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 9, 2023

This is part of a patch series adding cross-compilation support for
qtwebengine.

Description of changes

This PR adds perl to nativeBuildInputs (moving it from
buildInputs if already present) in order to allow cross-compiling.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from ttuegel as a code owner March 9, 2023 07:35
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Mar 9, 2023
@ghost ghost marked this pull request as draft March 9, 2023 07:39
@ofborg ofborg bot requested review from abbradar and periklis March 9, 2023 07:50
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 9, 2023
@ghost ghost closed this Mar 9, 2023
@ghost ghost deleted the pr/qt/nativeBuildInputs branch January 23, 2024 06:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants